Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't crash when ESLint is not loaded #267

Merged
merged 1 commit into from
Apr 22, 2024

Commits on Apr 22, 2024

  1. fix: don't crash when ESLint is not loaded

    Before ESLint 9, the plugin needed to be imported only when actually
    linting files. Tools inspecting the configuration didn't need to
    import the plugin, as the configuration was declared as a plain JSON.
    
    With ESLint 9, tools inspecting the configuration actually need to
    evaluate the configuration file wich imports the plugin. So it has a
    higher chance to be evaluated outside of ESLint.
    
    To allow such use case, don't throw an exception when the plugin is not
    loaded through ESLint, but rather display a warning. The bug report
    template should be enough to gather the needed information.
    
    Fixes #264
    BenoitZugmeyer committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    927ffc0 View commit details
    Browse the repository at this point in the history