Drop jest #266
Merged
Drop jest #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
drop-jest
branch
from
a6dcede
to
c589d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing with ESLint 9.1.0 following this change.
The
retrierlibrary tests that some promise isinstanceof Promise, but the condition fails because the promise seems to come from a different JavaScript realm, probably related to Jest usages ofvm(it could be related to jestjs/jest#2549, but the issue occurs solely within the dependencies, not the test code)Jest does not provide any benefit for this project, and now that we droped Node 14, we can just use de native Node Test Runner. Not only this fixes the issue, it removes a bit of maintenance, and run tests 2 times faster on my machine.