fix: skip the plugin if it's not in the config

CHANGELOG.md

@@ -2,6 +2,7 @@ UNRELEASED v8.1.0
 
 - Introduce the `html/ignore-tags-without-type` setting #249
 - Fix files with unknown extensions being considered as XML #257
+- Fix plugin applied even if it's not in the configuration #263
 - Update dependencies
 
 2024-02-09 v8.0.0

src/__tests__/plugin.js

@@ -4,7 +4,7 @@ const path = require("path")
 const eslint = require("eslint")
 const semver = require("semver")
 const eslintVersion = require("eslint/package.json").version
-require("..")
+const eslintPluginHtml = require("..")
 
 function matchVersion(versionSpec) {
   return semver.satisfies(eslintVersion, versionSpec, {
@@ -23,9 +23,12 @@ async function execute(file, options = {}) {
   let eslintOptions
   if (matchVersion(">= 9")) {
     eslintOptions = {
-      plugins: {
-        html: require(".."),
-      },
+      plugins:
+        options.usePlugin === false
+          ? {}
+          : {
+              html: eslintPluginHtml,
+            },
       baseConfig: {
         files: ["**/*.*"],
         settings: options.settings || {},
@@ -148,6 +151,23 @@ it("should extract and remap messages", async () => {
   }
 })
 
+ifVersion(
+  ">= 9",
+  it,
+  "does not apply the plugin if it is not used in the configuration",
+  async () => {
+    const messages = await execute("simple.html", {
+      usePlugin: false,
+      rules: {
+        "no-console": "error",
+      },
+    })
+
+    expect(messages.length).toBe(1)
+    expect(messages[0].message).toBe("Parsing error: Unexpected token <")
+  }
+)
+
 it("should report correct line numbers with crlf newlines", async () => {
   const messages = await execute("crlf-newlines.html")
 

src/index.js

@@ -5,6 +5,9 @@ const { createVerifyPatch } = require("./verifyPatch")
 const {
   createVerifyWithFlatConfigPatch,
 } = require("./verifyWithFlatConfigPatch")
+const pluginReference = require("./pluginReference")
+
+module.exports = pluginReference
 
 const LINTER_ISPATCHED_PROPERTY_NAME =
   "__eslint-plugin-html-verify-function-is-patched"

src/pluginReference.js

@@ -0,0 +1 @@
+module.exports = {}

src/verifyWithFlatConfigPatch.js

@@ -3,6 +3,7 @@ const getFileMode = require("./getFileMode")
 const extract = require("./extract")
 const { verifyWithSharedScopes } = require("./verifyWithSharedScopes")
 const { remapMessages } = require("./remapMessages")
+const pluginReference = require("./pluginReference")
 
 const PREPARE_RULE_NAME = "__eslint-plugin-html-prepare"
 const PREPARE_PLUGIN_NAME = "__eslint-plugin-html-prepare"
@@ -19,6 +20,10 @@ function createVerifyWithFlatConfigPatch(verifyWithFlatConfig) {
         providedOptions
       )
 
+    if (!Object.values(providedConfig.plugins).includes(pluginReference)) {
+      return callOriginalVerify()
+    }
+
     const pluginSettings = getSettings(providedConfig.settings || {})
     const mode = getFileMode(pluginSettings, providedOptions.filename)