chore(react-i18n): disable sideEffect to allow webpack tree-shaking #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Why?
When requiring the lib, webpack can't do its tree-shaking properly because of the commonjs require.
The problem I face is that, I need to import the translateFunction but I can't require it because when Webpack require the whole lib Next.JS throws an error because of the createContext used elsewhere in the lib. If we enable the treeshaking, only the function that I need will be imported and Next.JS won't throw an error.
馃捇 How?
sideEffects: falsein the package.json of react-i18n as specified in the webpack doc