Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-i18n): upgrade to react 17 #131

Merged
merged 4 commits into from May 16, 2023
Merged

chore(react-i18n): upgrade to react 17 #131

merged 4 commits into from May 16, 2023

Conversation

jsulpis
Copy link
Member

@jsulpis jsulpis commented May 11, 2023

  • the library react-i18n still required react 16 in peerDependencies
  • it supports react 17 without issue
  • so I allowed react 17 in the peerDependencies so that we have no warning when using the lib in a project with react 17, and no duplicate version of react

@coveralls
Copy link

coveralls commented May 11, 2023 •
edited by github-actions bot

Pull Request Test Coverage Report for Build 4989640137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.872%
Totals Coverage Status
Change from base Build 4123106557: 0.0%
Covered Lines: 131
Relevant Lines: 136
💛 - Coveralls

EtienneDOYON
EtienneDOYON approved these changes May 15, 2023
View reviewed changes
Copy link

@EtienneDOYON EtienneDOYON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@jsulpis
Publish
27f82b2 
 - @m6web/react-i18n@3.1.0
@jsulpis jsulpis merged commit b6b1f15 into master May 16, 2023
4 checks passed
@jsulpis jsulpis deleted the upgrade-react-17 branch May 16, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffjacquier fffjacquier fffjacquier approved these changes

@EtienneDOYON EtienneDOYON EtienneDOYON approved these changes

@CruuzAzul CruuzAzul CruuzAzul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsulpis @coveralls @fffjacquier @EtienneDOYON @CruuzAzul