refactor: remove atomic react methods (#206)

BREAKING CHANGE: Removes react method from atomic banks and cards clients.
Basis-Theory · Jun 30, 2022 · f2a200f · f2a200f
1 parent 6abb3f7
commit f2a200f
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 496 deletions.
diff --git a/.releaserc.json b/.releaserc.json
@@ -1,7 +1,12 @@
 {
   "branches": ["master"],
   "plugins": [
-    "@semantic-release/commit-analyzer",
+    [
+      "@semantic-release/commit-analyzer",
+      {
+        "releaseRules": [{ "type": "refactor", "release": "patch" }]
+      }
+    ],
     "@semantic-release/release-notes-generator",
     "@semantic-release/changelog",
     [

diff --git a/src/atomic/banks/BasisTheoryAtomicBanks.ts b/src/atomic/banks/BasisTheoryAtomicBanks.ts
@@ -2,8 +2,6 @@ import type { AxiosTransformer } from 'axios';
 import {
   createRequestConfig,
   dataExtractor,
-  proxyRaw,
-  transformAtomicReactionRequestSnakeCase,
   transformAtomicRequestSnakeCase,
   transformAtomicResponseCamelCase,
 } from '@/common';
@@ -13,8 +11,6 @@ import { CrudBuilder } from '@/service/CrudBuilder';
 import type {
   AtomicBank,
   CreateAtomicBank,
-  AtomicReactRequest,
-  ReactResponse,
   UpdateAtomicBank,
 } from '@/types/models';
 import type { PaginatedQuery, RequestOptions } from '@/types/sdk';
@@ -50,23 +46,6 @@ export const BasisTheoryAtomicBanks = new CrudBuilder(
         .patch(`/${id}`, request, createRequestConfig(options))
         .then(dataExtractor);
     }
-
-    public react(
-      tokenId: string,
-      request: AtomicReactRequest,
-      options?: RequestOptions
-    ): Promise<ReactResponse> {
-      return this.client
-        .post(
-          `/${tokenId}/react`,
-          request,
-          createRequestConfig(options, {
-            transformRequest: transformAtomicReactionRequestSnakeCase,
-            transformResponse: proxyRaw,
-          })
-        )
-        .then(dataExtractor);
-    }
   }
 )
   .create<AtomicBank, CreateAtomicBank>()

diff --git a/src/atomic/cards/BasisTheoryAtomicCards.ts b/src/atomic/cards/BasisTheoryAtomicCards.ts
@@ -1,10 +1,5 @@
 import type { AxiosTransformer } from 'axios';
-import {
-  createRequestConfig,
-  dataExtractor,
-  transformAtomicReactionRequestSnakeCase,
-  proxyRaw,
-} from '@/common';
+import { createRequestConfig, dataExtractor } from '@/common';
 import {
   transformAtomicRequestSnakeCase,
   transformAtomicResponseCamelCase,
@@ -15,8 +10,6 @@ import { CrudBuilder } from '@/service/CrudBuilder';
 import type {
   AtomicCard,
   CreateAtomicCard,
-  AtomicReactRequest,
-  ReactResponse,
   UpdateAtomicCard,
 } from '@/types/models';
 import type { PaginatedQuery, RequestOptions } from '@/types/sdk';
@@ -52,23 +45,6 @@ export const BasisTheoryAtomicCards = new CrudBuilder(
         .patch(`/${id}`, request, createRequestConfig(options))
         .then(dataExtractor);
     }
-
-    public react(
-      tokenId: string,
-      request: AtomicReactRequest,
-      options?: RequestOptions
-    ): Promise<ReactResponse> {
-      return this.client
-        .post(
-          `/${tokenId}/react`,
-          request,
-          createRequestConfig(options, {
-            transformRequest: transformAtomicReactionRequestSnakeCase,
-            transformResponse: proxyRaw,
-          })
-        )
-        .then(dataExtractor);
-    }
   }
 )
   .create<AtomicCard, CreateAtomicCard>()

diff --git a/src/common/utils.ts b/src/common/utils.ts
@@ -9,12 +9,7 @@ import os from 'os';
 import { snakeCase } from 'snake-case';
 import snakecaseKeys from 'snakecase-keys';
 import type { RequestTransformers } from '@/service';
-import type {
-  AtomicReactRequest,
-  Reactor,
-  Token,
-  TokenBase,
-} from '@/types/models';
+import type { Reactor, Token, TokenBase } from '@/types/models';
 import type {
   ApplicationInfo,
   ClientUserAgent,
@@ -96,22 +91,6 @@ const transformTokenRequestSnakeCase: AxiosTransformer = (
   } as Token;
 };
 
-const transformAtomicReactionRequestSnakeCase: AxiosTransformer = (
-  request: AtomicReactRequest
-): Token | undefined => {
-  if (typeof request === 'undefined') {
-    return undefined;
-  }
-
-  return {
-    ...snakecaseKeys(request, { deep: true }),
-    ...(request.requestParameters !== undefined
-      ? // eslint-disable-next-line camelcase
-        { request_parameters: request.requestParameters }
-      : {}),
-  } as Token;
-};
-
 const transformTokenResponseCamelCase: AxiosTransformer = (
   token: Token
 ): Token | undefined => {
@@ -288,7 +267,7 @@ const getQueryParams = <Q>(query: Q = {} as Q): string => {
 
         objectKeys.forEach((objectKey) => {
           appendSafe(
-            `${key}.${objectKey}`,
+            `${String(key)}.${objectKey}`,
             ((value as unknown) as Record<string, string>)[objectKey],
             true
           );
@@ -393,7 +372,6 @@ export {
   transformReactorRequestSnakeCase,
   transformAtomicRequestSnakeCase,
   transformTokenRequestSnakeCase,
-  transformAtomicReactionRequestSnakeCase,
   transformTokenResponseCamelCase,
   transformReactorResponseCamelCase,
   transformResponseCamelCase,

diff --git a/src/types/models/shared.ts b/src/types/models/shared.ts
@@ -24,22 +24,9 @@ interface TokenBase<T extends TokenType = TokenType> extends Auditable {
   fingerprint?: string;
   metadata?: Record<string, string>;
 }
-
-interface AtomicReactRequest {
-  reactorId: string;
-  requestParameters?: Record<string, unknown>;
-}
-
 interface ReactResponse {
   tokens: DataObject;
   raw: DataObject;
 }
 
-export type {
-  Primitive,
-  Auditable,
-  TokenType,
-  TokenBase,
-  AtomicReactRequest,
-  ReactResponse,
-};
+export type { Primitive, Auditable, TokenType, TokenBase, ReactResponse };
diff --git a/src/types/sdk/services/banks.ts b/src/types/sdk/services/banks.ts
@@ -3,21 +3,13 @@ import type {
   CreateAtomicBank,
   UpdateAtomicBank,
 } from '@/types/models';
-import type {
-  Create,
-  Retrieve,
-  Update,
-  Delete,
-  List,
-  AtomicReact,
-} from './shared';
+import type { Create, Retrieve, Update, Delete, List } from './shared';
 
 interface AtomicBanks
   extends Create<AtomicBank, CreateAtomicBank>,
     Retrieve<AtomicBank>,
     Update<AtomicBank, UpdateAtomicBank>,
     Delete,
-    List<AtomicBank>,
-    AtomicReact {}
+    List<AtomicBank> {}
 
 export type { AtomicBanks };
diff --git a/src/types/sdk/services/cards.ts b/src/types/sdk/services/cards.ts
@@ -3,21 +3,13 @@ import type {
   CreateAtomicCard,
   UpdateAtomicCard,
 } from '@/types/models';
-import type {
-  Create,
-  Retrieve,
-  Update,
-  Delete,
-  List,
-  AtomicReact,
-} from './shared';
+import type { Create, Retrieve, Update, Delete, List } from './shared';
 
 interface AtomicCards
   extends Create<AtomicCard, CreateAtomicCard>,
     Retrieve<AtomicCard>,
     Update<AtomicCard, UpdateAtomicCard>,
     Delete,
-    List<AtomicCard>,
-    AtomicReact {}
+    List<AtomicCard> {}
 
 export type { AtomicCards };
diff --git a/src/types/sdk/services/shared.ts b/src/types/sdk/services/shared.ts
@@ -1,5 +1,3 @@
-import type { AtomicReactRequest, ReactResponse } from '@/types/models';
-
 interface RequestOptions {
   apiKey?: string;
   correlationId?: string;
@@ -50,14 +48,6 @@ type List<T, Q extends PaginatedQuery = PaginatedQuery> = {
   list(query?: Q, options?: RequestOptions): Promise<PaginatedList<T>>;
 };
 
-type AtomicReact = {
-  react(
-    tokenId: string,
-    request: AtomicReactRequest,
-    options?: RequestOptions
-  ): Promise<ReactResponse>;
-};
-
 export type {
   RequestOptions,
   PaginatedQuery,
@@ -67,5 +57,4 @@ export type {
   Update,
   Delete,
   List,
-  AtomicReact,
 };