Skip to content

Commit

Permalink
fix: remove value setter generic altogether (#409)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinperaza committed Mar 18, 2024
1 parent 723eba1 commit 800cf4a
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/types/elements/elements.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ import type {
ElementMetadata,
} from './shared';

type ValueSetter<T> = (value: T) => void;

interface BaseElement<UpdateOptions, ElementEvents> {
readonly mounted: boolean;
readonly metadata: ElementMetadata;
Expand All @@ -54,7 +52,7 @@ type CardElement = BaseElement<UpdateCardElementOptions, CardElementEvents> & {
};

type TextElement = BaseElement<UpdateTextElementOptions, TextElementEvents> & {
setValueRef: ValueSetter<TextElement>;
setValueRef(value: TextElement): void;
setValue(value: DataElementReference): void;
};

Expand All @@ -63,15 +61,15 @@ type CardNumberElement = BaseElement<
CardNumberElementEvents
> & {
readonly cardMetadata?: CardMetadata;
setValueRef: ValueSetter<CardNumberElement>;
setValueRef(value: CardNumberElement): void;
setValue(value: DataElementReference): void;
};

type CardExpirationDateElement = BaseElement<
UpdateCardExpirationDateElementOptions,
CardExpirationDateElementEvents
> & {
setValueRef: ValueSetter<CardExpirationDateElement>;
setValueRef(value: CardExpirationDateElement): void;
setValue(value: CardExpirationDateValue<'reference'>): void;
month(): ElementWrapper<CardExpirationDateElement>;
year(): ElementWrapper<CardExpirationDateElement>;
Expand All @@ -82,7 +80,7 @@ type CardVerificationCodeElement = BaseElement<
UpdateCardVerificationCodeElementOptions,
CardVerificationCodeElementEvents
> & {
setValueRef: ValueSetter<CardVerificationCodeElement>;
setValueRef(value: CardVerificationCodeElement): void;
setValue(value: DataElementReference): void;
};

Expand Down

0 comments on commit 800cf4a

Please sign in to comment.