Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added static linux package building to support Alpine Linux #19

Merged
merged 3 commits into from Jul 6, 2021
Merged

Added static linux package building to support Alpine Linux #19

merged 3 commits into from Jul 6, 2021

Conversation

wbancer-reef
Copy link
Contributor

Changes required to build static linux package, to support non-glibc distributions (mainly made for Apline Linux)

mlech-reef
mlech-reef requested changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@mlech-reef mlech-reef left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to add CI to verify it is working on Alpine (Terraform official images)?

python-bindings/GNUmakefile Show resolved Hide resolved
@mlech-reef
Copy link
Collaborator

mlech-reef commented Jun 29, 2021 •
edited

We have:

pyinstaller~=4.1

but I believe it won't work with pyinstaler<4.3 as there was a problem with embedding files into executable when I tried to use staticx in the past. I see it was fixed in pyinstaller/pyinstaller#5511.

Please bump the required version.

@mszumocki-reef mszumocki-reef self-requested a review July 1, 2021 10:27
@mszumocki-reef mszumocki-reef changed the base branch from master to alpine-support July 6, 2021 09:17
@mszumocki-reef mszumocki-reef merged commit 4a0782c into Backblaze:alpine-support Jul 6, 2021
mszumocki-reef added a commit that referenced this pull request Jul 6, 2021
@mszumocki-reef
CR fixes, from #19
3eea95e
@mszumocki-reef
Copy link
Collaborator

I've merged this to local alpine-support branch instead of master and fixed code review remarks.

@mszumocki-reef mszumocki-reef mentioned this pull request Jul 6, 2021
Merged
mszumocki-reef added a commit that referenced this pull request Jul 6, 2021
@mszumocki-reef @wbancer-reef
Added static linux package building to support Alpine Linux (#20)
55e22f8 
* Added static linux package building to support Alpine Linux
* Updated deps files
* Updated changelog.
* CR fixes, from #19

Co-authored-by: Wojciech Bancer <wojciech.bancer@reef.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlech-reef mlech-reef mlech-reef requested changes

@mszumocki-reef mszumocki-reef Awaiting requested review from mszumocki-reef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wbancer-reef @mlech-reef @mszumocki-reef