New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow newer nextjs patchlevels, to fix problems on some systems #208
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/babylonjs/documentation/7uY6AciSQMD4uSxjsBxrLov3Pbb9 |
Thank you so much for that! next 10.0.6 had a serious issue that prevented us (and many other projects) from building correctly. This is why I am not very keen on using a Regarding the build issues with image optimization, I will put this on my todo list. the issue is with server-sided image optimization not available locally. |
reopening this - would you want to set the fixed version that works for you? I will test the build process and merge it then |
To eliminate the second error use |
Happy to sub in anything 10.0.7 or newer! Do you have a preference between 10.0.7 (the first version that works for me) and 10.0.9 (the latest 10.0.x)? |
latest fixed version is fine for me :-) Thanks!! |
…history of issues with nextjs point versions introducing bugs
OK! Changed from 10.0.x to 10.0.9, take another look? |
Fixes required for
yarn install
andyarn run dev
to work on my system (vanilla Ubuntu 20.04):Allow patchlevel updates of nextjs (10.0.x instead of 10.0.5). On my system, there's an issue in nextjs <10.0.7 with some complicated version interaction that causes sharp's install script to fail to find precompiled binaries for libvips; it tries to compile libvips from source, which doesn't work because expectations about certain header files (glib-object.h) don't match the system layout.
Add an explicit (dev) dependency on the same webpack version nextjs uses, due to issues Error: Cannot find module 'webpack' vercel/next.js#21679 (duped with Webpack inlining in Next v10.0.6 breaks treat/webpack-plugin vercel/next.js#21721). The root cause there is somewhat mysterious to me but without the webpack dependency, the dev-server can't generate pages, complaining that NodeTemplatePlugin is missing.
The
yarn.lock
changes that result from the above.Note, even after these changes,
yarn run build
doesn't work for me:I'm not sure if the HTML export step is supposed to work? (For local editing,
yarn run dev
is all you really need.) It seems like doc.babylonjs.com has a "Powered by Vercel" logo; does that mean Vercel is in fact serving the pages and handling the image optimization?