-
Notifications
You must be signed in to change notification settings - Fork 126
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updating to Babylon.js version 7.0.0 reveals a whole slew of issues when running the validation tests because [#14868](BabylonJS/Babylon.js#14868) broke the render loop stopping behavior when running in native. Native does not implement a way to cancel a requested animation frame. This missing canceling functionality should be added to native someday, but, in the meantime, [#15086](BabylonJS/Babylon.js#15086) will make it behave like it did before. These changes fix potential issues in the code regardless of what happened on the JS side. - Update to latest JsRuntimeHost with lots of fixes. - Call SetRenderResetCallback with null to clear the callback that can cause a crash on shutdown. - Update a few validation tests to not use render count. - Update scripts to use `const`/`let` instead of `var`. - Update validation script to handle some errors better and clean up dead code. - Add unhandled exception handler to Playground app so that validation test will report correct errors and exit correctly. - Change core graphics device implemenation to update bgfx state right before requesting screenshots. This will ensure the screenshot is the right size if the resolution has changed. - Fix TestUtils:WritePNG to return an error when the byte length is an unexpected size instead of silently failing. - Change TestUtils::SetTitle to update the HWND title on a background thread to avoid dead lock with the main thread. - Update dynamic texture clip test to newest version that will fail if the feature is not working.
- Loading branch information
Showing
42 changed files
with
486 additions
and
555 deletions.
There are no files selected for viewing
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file renamed
BIN
+1.13 MB
...ges/scissorTestWith0.9HardwareScaling.png → ...ground/ReferenceImages/scissor-test-2.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file renamed
BIN
+417 KB
...ges/scissorTestWith1.5HardwareScaling.png → ...ground/ReferenceImages/scissor-test-3.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.