Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setQuaternion to Effect #12633

Merged
merged 10 commits into from Jun 3, 2022
Merged

Conversation

BarthPaleologue
Copy link
Contributor

I'm back with more Quaternion's stuff.

I added setQuaternion to the Effect class.

I updated the different pipeline contexts versions to make it possible to set a quaternion as a uniform variable in a shader.
I created a IQuaternionLike interface, though it is the same as IVector4Like I think it makes the code easier to understand and read with this interface.

- lengthSquared
- subtractInPlace
- normalizeToNew
- invert
- invertInPlace
- applyRotationQuaternionToRef
- applyRotationQuaternionInPlace
- applyRotationQuaternion
- added a IQuaternionLike interface
- added setQuaternion to all pipelineContexts
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deltakosh deltakosh enabled auto-merge (squash) June 3, 2022 15:06
@azure-pipelines
Copy link

@deltakosh deltakosh merged commit 0140a1a into BabylonJS:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants