Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XR] No need to clear (depth) in utility layer #12613

Merged
merged 1 commit into from Jun 7, 2022
Merged

[XR] No need to clear (depth) in utility layer #12613

merged 1 commit into from Jun 7, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented May 31, 2022

This scene fails when in XR:

https://playground.babylonjs.com/#HJZBRG#253

Forum reference - https://forum.babylonjs.com/t/button3d-in-vr-is-rendered-on-top-of-everything/30772

I am not 100% sure why it was needed until now, so I am going to wait for reviews first before merging this.

@RaananW RaananW requested a review from bghgary May 31, 2022 15:31
@deltakosh
Copy link
Contributor

This is so weird. I have no idea why it was required. Maybe with WebVR?

@RaananW
Copy link
Member Author

RaananW commented May 31, 2022

This is so weird. I have no idea why it was required. Maybe with WebVR?

Right?... I have to be honest - I am the one who changed this line a few months back, but before it was even crazier. I thought maybe xr/native thing and am still trying to find the reason for that line.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bghgary
Copy link
Contributor

bghgary commented May 31, 2022

This is so weird. I have no idea why it was required. Maybe with WebVR?

Right?... I have to be honest - I am the one who changed this line a few months back, but before it was even crazier. I thought maybe xr/native thing and am still trying to find the reason for that line.

I don't think this is for native? We need to try to be sure I guess.

@RaananW
Copy link
Member Author

RaananW commented May 31, 2022

I don't think this is for native? We need to try to be sure I guess.

Will you be able to check without merging this PR?

@azure-pipelines
Copy link

@bghgary
Copy link
Contributor

bghgary commented May 31, 2022

Will you be able to check without merging this PR?

Yes, but I don't have time to do it soon. Maybe @CedricGuillemet @PolygonalSun @SergioRZMasson can try it?

@SergioRZMasson
Copy link
Contributor

I can take a look @bghgary .

@SergioRZMasson
Copy link
Contributor

I was able to validate that it is working with XR on mobile platforms, but it would be good to also test on a HMD. @PolygonalSun can you test it on your device?

@deltakosh
Copy link
Contributor

ping @PolygonalSun

Copy link
Contributor

@PolygonalSun PolygonalSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deltakosh deltakosh merged commit 205ee04 into BabylonJS:master Jun 7, 2022
@RaananW RaananW deleted the xr3DGuiFix branch June 10, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants