Move frame bar on ACE to the top of the window #12590
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12590/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12590/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12590/merge#BCU1XR#0 |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12590/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12590/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12590/merge#BCU1XR#0 |
There was a problem hiding this comment.
My only comment is asking about the isMounted flag, which is usually not needed. You can register observers once the component mounted, and remove them when unmounted. This way there is no need to check for the component's state.
It would also seem (unrelated to that PR!) that some observers are not cleared (for example onGraphMoved, onGraphScaled and so on) so removing them when the component isn't mounted anymore is anyhow needed.
.../components/actionTabs/tabs/propertyGrids/animations/curveEditor/graph/playHeadComponent.tsx
Outdated
Show resolved
Hide resolved
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12590/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12590/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12590/merge#BCU1XR#0 |
* WIP moving X axis to top * Positioning bar according to range * Add active frame indicator to range frame bar * Linting * Add proper observers to avoid ismounted
Previous:
With the PR: