New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XR] No need to clear (depth) in utility layer #12613
Conversation
This is so weird. I have no idea why it was required. Maybe with WebVR? |
Right?... I have to be honest - I am the one who changed this line a few months back, but before it was even crazier. I thought maybe xr/native thing and am still trying to find the reason for that line. |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
I don't think this is for native? We need to try to be sure I guess. |
Will you be able to check without merging this PR? |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12613/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12613/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12613/merge#BCU1XR#0 |
Yes, but I don't have time to do it soon. Maybe @CedricGuillemet @PolygonalSun @SergioRZMasson can try it? |
I can take a look @bghgary . |
I was able to validate that it is working with XR on mobile platforms, but it would be good to also test on a HMD. @PolygonalSun can you test it on your device? |
ping @PolygonalSun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This scene fails when in XR:
https://playground.babylonjs.com/#HJZBRG#253
Forum reference - https://forum.babylonjs.com/t/button3d-in-vr-is-rendered-on-top-of-everything/30772
I am not 100% sure why it was needed until now, so I am going to wait for reviews first before merging this.