Remove query type check, it relies on deprecated DBAL functionality w…

…ith no replacement (Fix #45)
BabDev · Nov 22, 2022 · cf60853 · cf60853
1 parent c391085
commit cf60853
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 18 deletions.
diff --git a/lib/Adapter/Doctrine/DBAL/QueryAdapter.php b/lib/Adapter/Doctrine/DBAL/QueryAdapter.php
@@ -4,7 +4,6 @@
 
 use Doctrine\DBAL\Query\QueryBuilder;
 use Pagerfanta\Adapter\AdapterInterface;
-use Pagerfanta\Exception\InvalidArgumentException;
 
 /**
  * Adapter which calculates pagination from a Doctrine DBAL QueryBuilder.
@@ -24,15 +23,9 @@ class QueryAdapter implements AdapterInterface
 
     /**
      * @phpstan-param callable(QueryBuilder): void $countQueryBuilderModifier
-     *
-     * @throws InvalidArgumentException if a non-SELECT query is given
      */
     public function __construct(QueryBuilder $queryBuilder, callable $countQueryBuilderModifier)
     {
-        if (QueryBuilder::SELECT !== $queryBuilder->getType()) {
-            throw new InvalidArgumentException('Only SELECT queries can be paginated.');
-        }
-
         $this->queryBuilder = clone $queryBuilder;
         $this->countQueryBuilderModifier = $countQueryBuilderModifier;
     }

diff --git a/lib/Adapter/Doctrine/DBAL/Tests/QueryAdapterTest.php b/lib/Adapter/Doctrine/DBAL/Tests/QueryAdapterTest.php
@@ -4,7 +4,6 @@
 
 use Doctrine\DBAL\Query\QueryBuilder;
 use Pagerfanta\Doctrine\DBAL\QueryAdapter;
-use Pagerfanta\Exception\InvalidArgumentException;
 
 final class QueryAdapterTest extends DBALTestCase
 {
@@ -21,16 +20,6 @@ protected function setUp(): void
         $this->qb->select('p.*')->from('posts', 'p');
     }
 
-    public function testANonSelectQueryIsRejected(): void
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Only SELECT queries can be paginated.');
-
-        $this->qb->delete('posts');
-
-        new QueryAdapter($this->qb, static function (QueryBuilder $qb): void { });
-    }
-
     public function testAdapterReturnsNumberOfResults(): void
     {
         $adapter = $this->createAdapterToTestGetNbResults();