Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running inside miri #387

Merged
merged 1 commit into from Mar 10, 2024
Merged

Support running inside miri #387

merged 1 commit into from Mar 10, 2024

Conversation

ryoqun
Copy link
Contributor

@ryoqun ryoqun commented Mar 7, 2024

hi :)

As the title just says, this pr adds minimal support for running under miri.

I wonder this pr could be merged without much hassle from me like enhancing ci... ;)

@oconnor663 oconnor663 merged commit e6e7f27 into BLAKE3-team:master Mar 10, 2024
50 checks passed
@oconnor663
Copy link
Member

Thanks! I've followed up with 2435e29 and d57818a to get cargo +nightly miri test working. It takes forever though, so I probably won't add it to CI 😅

@oconnor663
Copy link
Member

CI integration: 5b9af1c

@ryoqun
Copy link
Contributor Author

ryoqun commented Mar 12, 2024

@oconnor663 hey, really thanks for polishing the miri support. now that it's minimally covered even by ci, i have to ask you: why not 1.5.1? :) Thanks in advance.

@oconnor663
Copy link
Member

Good call, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants