build(CMake): Provide NEON cflags for ARMv8 32bit #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARMv8 CPUs are guaranteed to support NEON instructions. However, for 32bit ARMv8 triplets GCC needs to explicitly be configured to enable NEON intrinsics.
BurningEnlightenment
changed the title
|
LGTM |
|
@rui314 thanks for the Bug Report. |
oconnor663
reviewed
Nov 2, 2023
| @@ -0,0 +1,2 @@ | |||
| # CMakeLists.txt whitespace fixups | |||
| 3e14f865d30271c74fc68d417af488ea91b66d48 | |||
There was a problem hiding this comment.
The important parts look good to me, but I'm not sure it's worth having this file at the top level. I might be biased though, becuase I use fugitive.vim, which makes it easy to step across bulk commits with ~. What do you think?
There was a problem hiding this comment.
The GitHub Blame view respects this file, i.e. this is useful for anyone who just takes a glance at the code through the Web UI. Also VSCode has an inline line blame which becomes less useful if style commits aren't ignored.
And while it's usually easy to step through the latest few commits, it gets especially tedious after style changing commits layer up deep in the history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARMv8 CPUs are guaranteed to support NEON instructions. However, for 32bit ARMv8 triplets GCC needs to explicitly be configured to enable NEON intrinsics.
Different approach to fix the issue of #358