-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm32 SIMD Rust implementation #341
Open
monoid
wants to merge
8
commits into
BLAKE3-team:master
Choose a base branch
from
monoid:wasm-simd
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 11, 2023
-
This code is based on rust_sse2.rs of the same distribution, and is subject to further improvements. Some comments are left intact even if their applicability is questioned. SIMD implementation is gated by `wasm32-simd` feature, portable version is used otherwise. Performance measurements with a primitive benchmark with ~16Kb of data: | M1 native | 11,610 ns | | M1 WASM SIMD | 13,355 ns | | M1 WASM | 22,037 ns | | x64 native | 6,713 ns | | x64 WASM SIMD | 11,985 ns | | x64 WASM | 25,978 ns | wasmtime v12.0.1 was used on both platforms. Closes BLAKE3-team#187.
Configuration menu - View commit details
-
Copy full SHA for 909c6fc - Browse repository at this point
Copy the full SHA 909c6fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdeb9f7 - Browse repository at this point
Copy the full SHA cdeb9f7View commit details -
Remove unsafe from functions that do not need it
Wasm SIMD API has certain function safe.
Configuration menu - View commit details
-
Copy full SHA for 9221b99 - Browse repository at this point
Copy the full SHA 9221b99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87d286f - Browse repository at this point
Copy the full SHA 87d286fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dca1a10 - Browse repository at this point
Copy the full SHA dca1a10View commit details
Commits on Sep 21, 2023
-
Certain functions' unsafety comes from v128 loads and store. If argument types guarantee that these loads and stores are safe, function is declared safe, and internal unsafe blocks are commented.
Configuration menu - View commit details
-
Copy full SHA for e2a4953 - Browse repository at this point
Copy the full SHA e2a4953View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe8ef32 - Browse repository at this point
Copy the full SHA fe8ef32View commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 009438c - Browse repository at this point
Copy the full SHA 009438cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.