Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake target include directories #332

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

r4nx
Copy link
Contributor

@r4nx r4nx commented Aug 24, 2023

Include directory is not set if the library is used with add_subdirectory or FetchContent, this PR fixes it

Copy link
Collaborator

@BurningEnlightenment BurningEnlightenment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the suggestion I'm okay with this.

c/CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Henrik Gaßmann <BurningEnlightenment@users.noreply.github.com>
@r4nx
Copy link
Contributor Author

r4nx commented Nov 2, 2023

Apart from the suggestion I'm okay with this.

Thanks, sure, I've commited the changes

Copy link
Collaborator

@BurningEnlightenment BurningEnlightenment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oconnor663 oconnor663 merged commit 1930721 into BLAKE3-team:master Nov 5, 2023
50 checks passed
@r4nx r4nx deleted the fix_cmake_fetchcontent branch November 18, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants