build(cmake): Correctly detect x86 and arm64 Windows #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ISA names communicated by `CMAKE_SYSTEM_PROCESSOR` aren't as much standardized as one would wish they were. Factor the different names into lists allowing for simpler checks and future updates. Add hidden options for enabling SIMD support in case ISA detection fails. These should only be used to temporarily workarounds until the ISA name lists has been updated/fixed.
If no SIMD support could be configured we need to inform `blake3_dispatch.c` about it.
|
Thank you for putting all this effort in, and especially for the vcpkg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oconnor663 I hate to bother you again, but microsoft/vcpkg#31602 revealed that I missed a few
CMAKE_SYSTEM_PROCESSORvalues forx86andarm64. Furthermore I added escape hatches just in case that there are even more synonyms for these ISAs. See the commit messages for further details.I took this as an opportunity to log the active SIMD configuration.