Suppress MemorySanitizer false positive #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
force-pushed
the
suppress-msan-false-positive
branch
from
c272abe
to
4b31ae4
Compare
MemorySanitizer does not support assembly, and therefore produces a false positive on `blake3_hasher_finalize` and related functions.
jbms
force-pushed
the
suppress-msan-false-positive
branch
from
4b31ae4
to
680bdb5
Compare
|
Help me make sure I understand the problem. MSan thinks some memory is uninitialized, because the writes that initialized it were inside an assembly block/file that MSan can't analyze. Is that correct? That seems like it would be a problem for all sorts of libraries, like OpenSSL. Does OpenSSL include this sort of MSan hinting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemorySanitizer does not support assembly, and therefore produces a false positive on
blake3_hasher_finalizeand related functions.Note that a similar (but less comprehensive) fix was previously applied to LLVM's fork of this repo:
https://github.com/llvm/llvm-project/blob/34aff47521c3e0cbac58b0d5793197f76a304295/llvm/lib/Support/BLAKE3/blake3.c#L576