Update digest crate to 0.10 for traits-preview feature #215
Conversation
Adjust to the following changes that happened in digest: - The crypto-mac crate has been merged into digest (with "mac" feature enabled) - Various traits have been split up - The Digest and Mac traits now share their update/finalize/reset implementations - The BlockInput trait was dropped without replacement apparently (as long as the low-level core API is not used)
| @@ -85,8 +85,7 @@ arrayvec = { version = "0.7.0", default-features = false } | |||
| constant_time_eq = "0.1.5" | |||
| rayon = { version = "1.2.1", optional = true } | |||
| cfg-if = "1.0.0" | |||
| digest = { version = "0.9.0", optional = true } | |||
| crypto-mac = { version = "0.11.0", optional = true } | |||
| digest = { version = "0.10.1", features = [ "mac" ], optional = true } | |||
There was a problem hiding this comment.
Not a problem with this PR, but I think we have an issue where std = ["digest/std"] on line 26 unfortunately enables the digest feature all the time. So optional = true here isn't really behaving like we'd expect it to behave. Do you know of any way to solve this? Maybe we should just get rid of std = ["digest/std"]?
There was a problem hiding this comment.
Oops never mind. I just played with it, and while it's true that the digest dependency does get pulled in by default (no biggie), our traits-preview feature is not enabled by default. So callers still can't rely on these trait implementations without explicitly asking for the feature, which is what we really care about for (in)stability purposes.
| //! RustCrypto [`signature`] crate.) | ||
| //! RustCrypto [`digest`] crate, and re-exports those crates as | ||
| //! `traits::digest`. However, the traits aren't stable, and they're expected to | ||
| //! change in incompatible ways before those crates reach 1.0. For that reason, |
| @@ -901,8 +899,7 @@ fn parent_node_output( | |||
| /// | |||
| /// When the `traits-preview` Cargo feature is enabled, this type implements | |||
| /// several commonly used traits from the | |||
| /// [`digest`](https://crates.io/crates/digest) and | |||
| /// [`crypto_mac`](https://crates.io/crates/crypto-mac) crates. However, those | |||
| /// [`digest`](https://crates.io/crates/digest) crate. However, those | |||
| /// traits aren't stable, and they're expected to change in incompatible ways | |||
| /// before those crates reach 1.0. For that reason, this crate makes no SemVer | |||
|
Thank you! This will save me a lot of time looking through the change notes :) The comment tweaks suggested above aren't blocking. Feel free to make them, or I can make them myself after I land this. (EDIT: Done with c7b5881.) |
It was replaced with the |
Adjust to the following changes that happened in digest:
enabled)
implementations
long as the low-level core API is not used)
Related issue: #212 (not marked as closed by this PR, as discussion regarding the use the low-level API is still ongoing)