Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Playwright to 1.28 #5450

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/e2eTestUtils/ElectronPlaywrightTestUtils.ts
@@ -1,4 +1,4 @@
import { ElectronApplication, Page } from "playwright";
import { ElectronApplication, Page } from "playwright-core";
import * as fs from "fs";

export async function enterCredentials(page: Page, screenshot: Screenshot, username: string, accountPwd: string): Promise<void> {
Expand Down
3 changes: 1 addition & 2 deletions samples/msal-node-samples/ElectronTestApp/package.json
Expand Up @@ -20,10 +20,9 @@
"author": "",
"license": "MIT",
"devDependencies": {
"@playwright/test": "~1.27.0",
"@playwright/test": "~1.28.1",
"babel": "^6.23.0",
"electron": "^18.0.1",
"playwright": "~1.27.0",
"typescript": "^4.1.2"
},
"dependencies": {
Expand Down
@@ -1,7 +1,6 @@
import * as path from 'path';

import { ElectronApplication, Page, _electron as electron } from "playwright";
import { test, expect, } from "@playwright/test";
import { ElectronApplication, Page, _electron as electron, test, expect } from "@playwright/test";

import { setupCredentials } from "../../../e2eTestUtils/TestUtils";
import { NodeCacheTestUtils } from "../../../e2eTestUtils/NodeCacheTestUtils";
Expand Down
@@ -1,7 +1,6 @@
import * as path from 'path';

import { ElectronApplication, Page, _electron as electron } from "playwright";
import { test, expect, } from "@playwright/test";
import { ElectronApplication, Page, _electron as electron, test, expect } from "@playwright/test";

import { setupCredentials } from "../../../e2eTestUtils/TestUtils";
import { NodeCacheTestUtils } from "../../../e2eTestUtils/NodeCacheTestUtils";
Expand Down
39 changes: 7 additions & 32 deletions samples/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/package.json
Expand Up @@ -18,7 +18,7 @@
"dotenv": "^8.2.0",
"find-process": "^1.4.4",
"jest": "^27.1.1",
"playwright": "~1.27.0",
"playwright-core": "~1.28.1",
"puppeteer": "^19.2.0",
"ts-jest": "^27.0.5"
}
Expand Down