Add ClientException wrapper for native auth

[Yuki-YuXin]

Goal:

The SDK currently throws Exceptions in some flows (e.g. ClientException when an empty username is passed, refresh token exceptions, etc.). We should refactor this and replace it with exceptions being wrapped into an Error class and returned as a normal SDK response. Calling applications shouldn't crash, and shouldn't require try-catch blocks.
This will also involve updating the sample app (removing try-catch surrounding SDK methods being called)

Investigation summary:

• The incorrect configuration throws MsalClientException which it's inevitable and unsolvable by error class wrapper.
• Under CommandResultUtil.kt, the Exception has been wrapped as UnknownError.

 if (this.status != ICommandResult.ResultStatus.COMPLETED) {
        var exception: Exception? = null
        var exceptionMessage: String? = ""

        if (this.result is Exception) {
            exception = this.result as Exception
            exceptionMessage = exception.message
        }

        return com.microsoft.identity.common.java.nativeauth.controllers.results.INativeAuthCommandResult.UnknownError(
            error = UNSUCCESSFUL_COMMAND_ERROR,
            errorDescription = exceptionMessage,
            exception = exception,
            correlationId = this.correlationId
        ) as ExpectedType

• BaseNativeAuthController throws ClientException. They could only be called in NativeAuthMsalController and we didn't.

• NativeAuthMsalController throws IOException::class, ClientException::class, ServiceException::class ArgumentException::class, ServiceException::class. mainly from acquireTokenSilent & renewAT used by AcquireTokenNoFixedScopesCommand (accountState.getAccessToken). It will be handled by is Exception in getAccessToken`

• AcquireTokenNoFixedScopesCommandParameters throws ArgumentException -> this parameter will be delted

• Request throws ClientException -> NativeAuthRequestHandlerTest include

• verifyNoUserIsSignedIn() throws MsalClientException

Changes summary:

1. Add GetAccountError and SignOutError error in Error.kt
2. Use try catch block with corresponding errors in interface methods.

Company PRs:

native sample app: Azure-Samples/ms-identity-ciam-native-auth-android-sample#24

[SammyO]

nit: let's update this comment: // This should be caught earlier in the flow, so returning generic error

[SammyO]

Where is ErrorTypes.UNSUCCESSFUL_COMMAND_ERROR set?

[Yuki-YuXin]

It set under CommandResultUtil.kt const val UNSUCCESSFUL_COMMAND_ERROR = "unsuccessful_command"

[SammyO]

I don't think those changes are pushed, I don't see them in this PR.

[Yuki-YuXin]

They originally existed in the common repository.

[SammyO]

But this PR also introduces const val UNSUCCESSFUL_COMMAND_ERROR = "unsuccessful_command" in Error.kt. Is that one used?

[Yuki-YuXin]

It isn't used in the SDK code base because this PR just adds try catch block with ErrorType = "client_exception".
ErryType = "unsuccessful_command" is defined wrapping exceptions in common repo under CommandResultUtil.
However, the existing "unsuccessful_command" has some difference from "client_exception" in my opinion. They can't replace each other.
"unsuccessful_command" is used in the appending test testEmptyRequestParametersToGenericErrorNotThrownException() and will be displayed in the sample app to user SubmitError(error= "unsuccessful_command").
We cannot use assertTrue((submitCodeResult as SubmitCodeError).error.equals(CommandResultUtil.UNSUCCESSFUL_COMMAND_ERROR)) instead of assertTrue((submitCodeResult as SubmitCodeError).error.equals(ErrorTypes.UNSUCCESSFUL_COMMAND_ERROR)) in the NativeAuthPublicClientApplicationKotlinTest
We can either remove testEmptyRequestParametersToGenericErrorNotThrownException() test or remove the introduction.

[Yuki-YuXin]

Offline discussion conclusion: Use direct string in the test file instead of adding new definition in the code base.