Update consumer-rules.pro #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSON's TypeAdapter is an abstract class, not an interface.
|
The proguard config that we ship has the verbatim guidance from google's repo: If you believe there's an issue with this config, I'd try to submitting an issue over there -- if that merges, we can take it here |
iambmelt
added
the
More Info
|
Done. See google/gson#1693 |
iambmelt
added
Bug - P2
|
@MariusVolkhart Brilliant. Thanks I'll take the liberty of updating this branch with the latest changes for a clean merge. Thank you for your contribution! |
iambmelt
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GSON's TypeAdapter is an abstract class, not an interface.