Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Maintenance, May 2024 #2406

Merged
merged 24 commits into from
May 31, 2024
Merged

UI Maintenance, May 2024 #2406

merged 24 commits into from
May 31, 2024

Conversation

fadidurah
Copy link
Contributor

@fadidurah fadidurah commented May 14, 2024

  • Removed UncaughtExceptionHandlerRule, seems to be broken and causing some tests to run forever. I tried some fixes, but no luck keeping the rule and also fixing tests.
  • Fix parameter in lab api for ONPREM
  • Fix Cert in Common Testing utilities pipeline
  • Adjustments to Chrome HandleFirstRun
  • Add fallback in prompt handling methods to check for object by class, if resource ids are not working (saw some issues on local device where chrome wouldn't export resource ids, also appeared to happen in webview sometimes. Seemed to be happening constantly in ADFS (although this seems like an issue from ests side)). Either side, not a blocker for us with this fix.

@fadidurah fadidurah marked this pull request as ready for review May 16, 2024 19:44
@fadidurah fadidurah requested a review from a team as a code owner May 16, 2024 19:44
@fadidurah fadidurah added the No-Changelog This Pull-Request has no associated changelog entry. label May 23, 2024
@fadidurah fadidurah changed the title Fadi/UI fixes UI Maintenance, May 2024 May 23, 2024
@fadidurah fadidurah added the Skip-Consumers-Check Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR label May 31, 2024
@fadidurah fadidurah merged commit 877fb16 into dev May 31, 2024
12 of 13 checks passed
fadidurah added a commit to AzureAD/microsoft-authentication-library-for-android that referenced this pull request May 31, 2024
Various adjustments to MSAL-only and MSAL/Broker Tests. Some tests were
removed to be ran manually as part of release, some tests were adjusted,
and some test files were removed corresponding to tests that have been
migrated to integration testing. Changes in common were taken in to fix
some broker automation.

Common:
AzureAD/microsoft-authentication-library-common-for-android#2406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-Changelog This Pull-Request has no associated changelog entry. Skip-Consumers-Check Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants