-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Maintenance, May 2024 #2406
Merged
Merged
UI Maintenance, May 2024 #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fadidurah
commented
May 14, 2024
•
edited
edited
- Removed UncaughtExceptionHandlerRule, seems to be broken and causing some tests to run forever. I tried some fixes, but no luck keeping the rule and also fixing tests.
- Fix parameter in lab api for ONPREM
- Fix Cert in Common Testing utilities pipeline
- Adjustments to Chrome HandleFirstRun
- Add fallback in prompt handling methods to check for object by class, if resource ids are not working (saw some issues on local device where chrome wouldn't export resource ids, also appeared to happen in webview sometimes. Seemed to be happening constantly in ADFS (although this seems like an issue from ests side)). Either side, not a blocker for us with this fix.
fadidurah
added
the
No-Changelog
This Pull-Request has no associated changelog entry.
label
May 23, 2024
melissaahn
approved these changes
May 29, 2024
rpdome
approved these changes
May 30, 2024
...rosoft/identity/client/ui/automation/interaction/microsoftsts/AdfsLoginComponentHandler.java
Show resolved
Hide resolved
fadidurah
added
the
Skip-Consumers-Check
Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR
label
May 31, 2024
fadidurah
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
May 31, 2024
Various adjustments to MSAL-only and MSAL/Broker Tests. Some tests were removed to be ran manually as part of release, some tests were adjusted, and some test files were removed corresponding to tests that have been migrated to integration testing. Changes in common were taken in to fix some broker automation. Common: AzureAD/microsoft-authentication-library-common-for-android#2406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
No-Changelog
This Pull-Request has no associated changelog entry.
Skip-Consumers-Check
Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.