Update logic for matching requested claims for AT #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorinung
reviewed
May 7, 2024
common4j/src/main/com/microsoft/identity/common/java/cache/AbstractAccountCredentialCache.java
Outdated
Show resolved
Hide resolved
sansrivastav
changed the title
nickbopp
reviewed
May 23, 2024
common4j/src/main/com/microsoft/identity/common/java/cache/AbstractAccountCredentialCache.java
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
May 24, 2024
...src/test/java/com/microsoft/identity/common/SharedPreferencesAccountCredentialCacheTest.java
Show resolved
Hide resolved
mohitc1
reviewed
May 28, 2024
common4j/src/main/com/microsoft/identity/common/java/cache/AbstractAccountCredentialCache.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic of matching credentials only compares requested claims when we specify requested claims.
So, if there are 2 accesss tokens in storage:
AT1 - with no requested claims specified
AT2 - with a specific requested claims RC2
And then we query the storage without specifying any claims, current logic returns both AT1 and AT2.
The proposed change overrides getCredentialsFilteredBy() adding an extra boolean mustMatchExactClaims. When this parameter is set, we match claims explicitly even when no claims are provided. In the case above, only AT1 will be returned.
We will call this new overloaded method from MSAL CPP so that the behavior of MSAL CPP is same across all platforms including Android.