Extract the mock api url from code to pipeline argument #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuki-YuXin
added
No-Changelog
Yuki-YuXin
changed the title
SammyO
reviewed
May 17, 2024
common4j/build.gradle
Outdated
| @@ -164,6 +165,11 @@ if (project.hasProperty("useMockApiForNativeAuth")) { | |||
| useMockApiForNativeAuthParameter = useMockApiForNativeAuth | |||
| } | |||
|
|
|||
| if (project.hasProperty("mockApiUrl")) { | |||
| mockApiUrlParameter = mockApiUrl.toString() | |||
There was a problem hiding this comment.
I don't think you need to call toString() here.
…into yuki/extract-mock-api-pipeline
Yuki-YuXin
added
the
Skip-Consumers-Check
Yuki-YuXin
changed the title
SammyO
approved these changes
May 17, 2024
|
@shahzaibj @p3dr0rv @fadidurah This PR makes change on pipeline yml files. Could I kindly ask for your confirmation and review in case I missed something that could cause issues to the pipeline. For the skiped MSAL consumers check, I will add -PmockApiUrl=$(MOCK_API_URL) later in msal repo. Many thanks! |
p3dr0rv
approved these changes
May 20, 2024
Yuki-YuXin
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Mock API domain is hardcoded in our test source files. This domain should not be publicly known.
Please refer to #2387 for comments related with the PR.
Company MSAL PR: AzureAD/microsoft-authentication-library-for-android#2103