fix: makes the x5c header available #1543
Conversation
|
@brentschmaltz can you have a look into this PR? It is stopping development :-( |
|
@brentschmaltz and @GeoK Any hope, you could approve this PR soon? |
|
@brentschmaltz @GeoK Any thoughts on this? |
| /// Gets the certificate used to sign the token | ||
| /// </summary> | ||
| /// <remarks>If the 'x5c' claim is not found, null is returned.</remarks> | ||
| public string X5c => GetStandardClaim(JwtHeaderParameterNames.X5c); |
There was a problem hiding this comment.
x5c header should be string[] (see https://tools.ietf.org/html/rfc7515#section-4.1.6)
There was a problem hiding this comment.
I'll work on that.
|
@brentschmaltz Thank you for merging! Do you have an ETA when it will be available in the NUGET package? |
|
@RufusJWB about a week or so. |
|
Currently I'm not able to get the Unit tests running in Visual Studio. So as soon as the header is in NUGET package I'll try to update the return to string[]. |
|
@RufusJWB we delay sign so we use SN to turn off checking for our assemblies. |
Making the x5c header available would be the first step to fix #1542