setup-helm refactor #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asgayle/setup helm refactor
|
Ran tests on all runners here https://github.com/taakleton/setup-helm-refac-test/actions/runs/1746277260 |
tbarnes94
approved these changes
Jan 26, 2022
OliverMKing
reviewed
Jan 26, 2022
OliverMKing
requested changes
Jan 26, 2022
There was a problem hiding this comment.
Changes above + might be good to refactor the order of the functions. It's hard to read right now because the flow isn't top to bottom.
For example, run() is the entrypoint of application so someone looking to see what's going on would start there. That would be the top. Then getLatestHelmVersion() is called next so that would be right below run(). And so on...
OliverMKing
approved these changes
Jan 26, 2022
1 task
This was referenced Apr 11, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored getLatestHelmVersion to not require github token (addressing this issue) and removed support for legacy helm V2 versions. Legacy users can use older versions of the action to install helm.