Added setup-helm : Install helm binary #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const helmpath = findHelm(cachedToolpath); | ||
| if (!helmpath) { | ||
|
|
||
| } |
There was a problem hiding this comment.
If ! throw some warning?
| function findHelm(rootFolder: string): string { | ||
| fs.chmodSync(rootFolder, '777'); | ||
| var filelist: string[] = []; | ||
| walkSync(rootFolder, filelist, helmToolName + getExecutableExtension()); |
There was a problem hiding this comment.
Why do you need this? You could use tl.find?
There was a problem hiding this comment.
its not there in tool-cache
the find function in tool-cache is only for tools and not for paths
src/run.ts
Outdated
|
|
||
| var walkSync = function(dir, filelist, fileToFind) { | ||
| var fs = fs || require('fs'), | ||
| files = fs.readdirSync(dir); |
There was a problem hiding this comment.
Split it into 2 lines, also add the require statement globally. Otherwise, you'd be bringing it into memory in every stack call.
| @@ -0,0 +1,122 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // Licensed under the MIT license. | |||
There was a problem hiding this comment.
This is not required?
There was a problem hiding this comment.
It was mentioned in the workitem that ariel sent for compliance
| @@ -0,0 +1,15 @@ | |||
| name: 'Helm tool installer' | |||
| description: 'Install a specific version of helm binary. Acceptable values are latest or any semantic version string like 1.15.0' | |||
There was a problem hiding this comment.
already mentioned latest
thesattiraju
approved these changes
Oct 15, 2019
1 task
This was referenced Apr 11, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.