Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.1] Update tokio, rayon, and crossbeam to latest compatible versions #6135

Merged
merged 5 commits into from Feb 23, 2022

Conversation

onalante-msft
Copy link
Contributor

crossbeam-utils recently patched an unsoundness bug in AtomicCell arithmetic: crossbeam-rs/crossbeam#781. However, this patch was not backported to the older versions required by tokio 0.1 and rayon. This PR updates tokio and rayon to the latest available versions to unify our crossbeam dependencies, in particular unifying crossbeam-util to version 0.7.2. In the process, we can verify that we are not affected by the unsoundness bug by attempting a build with crossbeam-util patched to remove AtomicCell arithmetic.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

@onalante-msft onalante-msft changed the title [release/1.1] Update tokio and rayon to latest compatible versions [release/1.1] Update tokio, rayon, and crossbeam to latest compatible versions Feb 18, 2022
edge-modules/edgehub-proxy/Cargo.lock Outdated Show resolved Hide resolved
Accidentally left local reference inside.
@kodiakhq kodiakhq bot merged commit dc30b65 into Azure:release/1.1 Feb 23, 2022
@onalante-msft onalante-msft deleted the crossbeam-1.1 branch February 23, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants