Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-aria-live react 18 support #3005

Conversation

JamesBurnside
Copy link
Member

@JamesBurnside JamesBurnside commented May 1, 2023

What

Move react-aria-live to our repo (+small conversion to functional component style)

Why

Package has a hard peer dep on react 16. We are moving to support react 18 (see: #1900)

How Tested

  • ✅ unit tests added
  • ✅ Local testing appears to work as best I can tell:
    before after
    image image
    image image

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Chat bundle size is decreased✅.

  • Current size: 9836209
  • Base size: 9839747
  • Diff size: -3538

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

CallWithChat bundle size is decreased✅.

  • Current size: 10187180
  • Base size: 10191715
  • Diff size: -4535

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Calling bundle size is decreased✅.

  • Current size: 9791685
  • Base size: 9797692
  • Diff size: -6007

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

@JamesBurnside JamesBurnside marked this pull request as ready for review May 1, 2023 20:05
@JamesBurnside JamesBurnside requested review from a team as code owners May 1, 2023 20:05
Copy link
Member

@dmceachernmsft dmceachernmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! this is just for the message thread? is this announcer (since it is much more powerful than the one I made) something we want to start adapting into new components in the furture/update existing announcers?

@JamesBurnside
Copy link
Member Author

JamesBurnside commented May 1, 2023

This is really cool! this is just for the message thread? is this announcer (since it is much more powerful than the one I made) something we want to start adapting into new components in the furture/update existing announcers?

We can reuse this throughout. I just super quickly copy-converted over the underlying library as it was very small so should be essentially a no-op but we can definitely integrate this into calling as well to avoid multiple announcement. Honestly though we need a stateful-driven announcer instead of the announcements being driven at the individual react-component layer as the react-components don't have context of the whole app to make a good, informed decision about whether to announce or not

@JamesBurnside JamesBurnside merged commit 0300a63 into feature/react-18-short-term-support May 1, 2023
27 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/react-aria-live-swapout branch May 1, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants