-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-aria-live
react 18 support
#3005
react-aria-live
react 18 support
#3005
Conversation
Chat bundle size is decreased✅.
|
CallWithChat bundle size is decreased✅.
|
Calling bundle size is decreased✅.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool! this is just for the message thread? is this announcer (since it is much more powerful than the one I made) something we want to start adapting into new components in the furture/update existing announcers?
We can reuse this throughout. I just super quickly copy-converted over the underlying library as it was very small so should be essentially a no-op but we can definitely integrate this into calling as well to avoid multiple announcement. Honestly though we need a stateful-driven announcer instead of the announcements being driven at the individual react-component layer as the react-components don't have context of the whole app to make a good, informed decision about whether to announce or not |
0300a63
into
feature/react-18-short-term-support
What
Move react-aria-live to our repo (+small conversion to functional component style)
Why
Package has a hard peer dep on react 16. We are moving to support react 18 (see: #1900)
How Tested