Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasl
Copy link

@jasl jasl commented Jan 6, 2021

In my experience, this usage maybe wrong

if RUBY_VERSION < "2.4.0"
  s.add_runtime_dependency("nokogiri",                "~> 1.10.4")
else
  s.add_runtime_dependency("nokogiri",                "~> 1.11.0.rc2")
end
  • this piece of codes should be running in developer's PC, not end users', a proof is https://rubygems.org/gems/azure-storage-blob which shows azure-storage-blob depends on nokogiri ~> 1.11.0.rc2
  • Relex the version to ~> 1.10 is enough for all versions of Rubies, the bundler can find the best match version

I found this because sparklemotion/nokogiri#2168 (comment)

In addition

I also relex faraday_middleware

@ghost
Copy link

ghost commented Jan 6, 2021

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Jan 6, 2021

Coverage Status

Coverage increased (+0.05%) to 87.08% when pulling 726fb12 on jasl:relex-nokogiri into 05ea58a on Azure:master.

@jasl jasl changed the title Relax Nokogiri Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement Jan 6, 2021
@jasl
Copy link
Author

jasl commented Jan 6, 2021

BTW, if the PR merged, could you release a new version?

Copy link

@nertzy nertzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is more in line with standard Ruby expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants