Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Don't treat any empty lines as headers #192

Merged
merged 1 commit into from Aug 15, 2019
Merged

Don't treat any empty lines as headers #192

merged 1 commit into from Aug 15, 2019

Conversation

spaze
Copy link
Contributor

@spaze spaze commented Jul 17, 2019

First check if the header line is empty, and only parse it as a header line if it's not.

Fix #191

@XiaoningLiu
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ScottHelme
Copy link

Just checking in on this, would be cool to get an update! 👍

@XiaoningLiu
Copy link
Member

XiaoningLiu commented Aug 15, 2019

@vinjiang Please help merge. Failed case doesn't relate to this change. Start rerun the pipeline.

@XiaoningLiu
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vinjiang vinjiang merged commit bed9d2a into Azure:dev Aug 15, 2019
@spaze
Copy link
Contributor Author

spaze commented Nov 19, 2019

Hi folks! Can we please get this merged to master and released? Thanks!

@XiaoningLiu
Copy link
Member

Thanks @spaze ! Will check with our team about next release schedule.

@spaze
Copy link
Contributor Author

spaze commented Dec 30, 2019

Hi, can we please get this released? It's been a while. Thanks.

@XiaoningLiu
Copy link
Member

XiaoningLiu commented Dec 31, 2019

Hi @spaze We are preparing for a release planned in this week by @katmsft

@spaze
Copy link
Contributor Author

spaze commented Jan 2, 2020

Thank you for the release @XiaoningLiu & @katmsft!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants