This repository has been archived by the owner on May 8, 2024. It is now read-only.
Don't treat any empty lines as headers #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
XiaoningLiu
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just checking in on this, would be cool to get an update! 👍 |
@vinjiang Please help merge. Failed case doesn't relate to this change. Start rerun the pipeline. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi folks! Can we please get this merged to master and released? Thanks! |
Thanks @spaze ! Will check with our team about next release schedule. |
Hi, can we please get this released? It's been a while. Thanks. |
Thank you for the release @XiaoningLiu & @katmsft! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First check if the header line is empty, and only parse it as a header line if it's not.
Fix #191