Set flag parsing to exit on error to ensure exit status is non zero #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to ensure exit status is non zero
gapra-msft
requested review from
souravgupta-msft,
tasherif-msft and
vibhansa-msft
vibhansa-msft
approved these changes
Apr 14, 2022
vibhansa-msft
approved these changes
Apr 15, 2022
tasherif-msft
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #735
I have created a draft PR against cobra to help resolve this issue, pointing to my branch until we can get that merged. spf13/cobra#1662
Will add tests once I get some feedback on this idea