Update helm charts with AzurePublicIPAddress.ipTags and new kustomize #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of kustomize no longer word-wraps long text fields like descriptions, which causes a lot of churn in the files. This was changed in kubernetes-sigs/kustomize#2678 released with kustomize 3.7.0 (after discussion on this bug kubernetes-sigs/kustomize#947).
babbageclunk
requested review from
davefellows,
frodopwns,
jananivMS,
matthchr,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
babbageclunk
commented
Aug 5, 2020
| @@ -46,9 +41,11 @@ spec: | |||
| properties: | |||
| idleTimeoutInMinutes: | |||
| type: integer | |||
| ipTags: | |||
There was a problem hiding this comment.
The actual change from #1246.
theunrepentantgeek
approved these changes
Aug 6, 2020
| @@ -32,8 +31,7 @@ spec: | |||
| singular: azuresqldatabase | |||
| preserveUnknownFields: false | |||
| scope: Namespaced | |||
| subresources: | |||
| status: {} | |||
| subresources: {} | |||
| version: v1alpha1 | |||
There was a problem hiding this comment.
It seems like this is an omitempty that's been added somewhere in the toolchain. (It's in the original PR too.)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This regenerates the helm charts with the new field added in #1246.
The new version of kustomize no longer word-wraps long text fields like descriptions, which causes a lot of churn in the files. This was changed in kubernetes-sigs/kustomize#2678 released with kustomize 3.7.0 (after discussion on this bug kubernetes-sigs/kustomize#947).
Special notes for your reviewer:
This was split from #1249 so that the specific port changes weren't lost in the description changes.
How does this PR make you feel:
Relieved.
If applicable: