Storage crate reorg and cleanup #194
Conversation
MindFlavor
added
Client
| @@ -1,5 +1,5 @@ | |||
| use azure_core::prelude::*; | |||
| use azure_storage::blob::prelude::*; | |||
| use azure_storage::blob_storage::prelude::*; | |||
There was a problem hiding this comment.
What was the reasoning behind adding the storage suffix to all the submodules?
There was a problem hiding this comment.
I've explained below, it's for the module inception: tight now there is a blob module inside the blob module. Now we have the blob module inside the blob_storage module (which I think makes sense)
|
For example, the current master has a module table inside a module called table. Clippy complains with:
I cannot think of a better solution than appending |
|
@MindFlavor putting the the table model into a module called |
| @@ -98,8 +98,8 @@ fn format<D: Display>(value: D) -> String { | |||
| pub fn to_str_without_bom(bytes: &bytes::Bytes) -> Result<&str, std::str::Utf8Error> { | |||
| let s = from_utf8(bytes)?; | |||
|
|
|||
| Ok(if s.starts_with('\u{FEFF}') { | |||
| &s[3..] | |||
| Ok(if let Some(stripped) = s.strip_prefix('\u{FEFF}') { | |||
There was a problem hiding this comment.
Nit: I think the following is clearer:
s.strip_prefix('...').unwrap_or(s)
heaths
added
the
design-discussion
This is a seemly big PR but it's mostly code shuffling. With this PR I believe we are very close to release v0.1! 馃
Purpose
blob_storage,table_storage, etc... to avoid module inception (see https://rust-lang.github.io/rust-clippy/master/index.html#module_inception).blob_storagespecific clients fromcoreto the appropriate module.azure_storagewithout default features or combinations of features less than the default聽#177). Right now by default it compiles everything but you can, say, usetable_storagewithout anything else.hyper(to support target wasm & wasi too聽#37). 馃嵕ok_or_elseetc...). The only "significant" change is the switch fromIntotoFrom. Now the crate is clippy-compliant. 馃嵕Cons
hyperdependency I had to remove the ability to generate signed URIs. We will reenable it in a future PR.