Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from http-types to http #1662

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

svix-jplatte
Copy link

Closes #1644.

For the second commit, I used sed as I couldn't figure out the right rev of azure-rest-api-specs to check out to get identical output (aside from the intended changes). When I had it checked out at the rev referenced in #1496 (the latest such PR I could find), it still added and removed a bunch of files.

I split the PR into two commits to make review easier, but this should likely be squash-merged as the first commit does not compile on its own.

This was done using sed replacements of the form
for file in **/*.rs; do sed -i 's/azure_core::Method::Get/azure_core::Method::GET/g' "$file"; done
@svix-jplatte svix-jplatte marked this pull request as ready for review May 15, 2024 11:36
@svix-jplatte
Copy link
Author

@microsoft-github-policy-service agree company="Svix"

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on discussion in #1644. Also, this may be too big of a change for unofficial sources given near-term plans.

@svix-jplatte
Copy link
Author

Re. the size of the change, would it help if you just re-did the second commit on your end? It's really just the sed command I put into its description, which needs to be run for the following replacements one-by-one in addition the Get one already provided:

  • s/azure_core::Method::Head/azure_core::Method::HEAD/g
  • s/azure_core::Method::Post/azure_core::Method::POST/g
  • s/azure_core::Method::Put/azure_core::Method::PUT/g
  • s/azure_core::Method::Delete/azure_core::Method::DELETE/g
  • s/azure_core::StatusCode::Ok/azure_core::StatusCode::OK/g
  • s/azure_core::StatusCode::Accepted/azure_core::StatusCode::ACCEPTED/g
  • s/azure_core::StatusCode::Created/azure_core::StatusCode::CREATED/g
  • s/azure_core::StatusCode::NoContent/azure_core::StatusCode::NO_CONTENT/g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider replacing http-types crate with http crate
2 participants