Add support for cloud to device messages #1490
Conversation
|
@heaths I would like your feedback on this from a future-project direction standpoint. For other languages, separate libraries are maintained outside of the Azure SDK.
Thus far, we've had limited updates for the azure_iot_hub crate maintained in this repo. How should we move forward with regards to this and future features for azure_iot_hub? |
|
Are there any updates on this topic? I would love to have support for cloud-to-device messages in the current crate. I don't oppose having it as a separate repo, but in any case, it would be nice to have this merged before that happens. |
|
Sorry for the delay. This dropped off my radar. I believe the other languages, it was done that way because of legacy. The service team supports them themselves but still mostly follows the Azure SDK guidelines. For the Rust SDKs, we'll need to find out. I'll figure out appropriate contacts and add them to this PR to discuss. |
| /// use azure_iot_hub::service::ServiceClient; | ||
| /// use std::collections::HashMap; | ||
| /// | ||
| /// # let connection_string = "HostName=cool-iot-hub.azure-devices.net;SharedAccessKeyName=iot_hubowner;SharedAccessKey=YSB2ZXJ5IHNlY3VyZSBrZXkgaXMgaW1wb3J0YW50Cg=="; |
There was a problem hiding this comment.
This secret must be removed and you should rotate it immediately. Do not put secrets in the repo. Mark this code fence no_run and use environment variables in your example.
There was a problem hiding this comment.
Use the same ones as your other example.
There was a problem hiding this comment.
It's not a real secret, if you base64 decode it you'll realize.
There was a problem hiding this comment.
Our secret scanner may still flag it. It doesn't decode the values (most won't be ASCII anyway). Since the value won't work anyway, you could just leave it blank.
| let properties = std::env::args().nth(3).map(|s| { | ||
| s.split(',') | ||
| .map(|s| { | ||
| let mut split = s.split('='); |
There was a problem hiding this comment.
Nit: I'd use splitn(2, '=') here to get the rest as the value.
|
Thanks for the comments. I'll clean this up and push the fixes. |
Adds support for cloud-to-device messages.