use tz::TimeZone for az-cli time conversion on unix platforms #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in Azure#1371, there are numerous issues with handling the az-cli's output of an access token's expiration date when it comes to time zones. An update to the Azure CLI is in progress that will add a _new_ field that will handle the conversion, currently tracked as Azure/azure-cli#27476. We should make use of this new feature once it's available, but we should also keep this functionality as a fallback for supporting older Azure CLIs.
cataggar
approved these changes
Oct 3, 2023
demoray
pushed a commit
to demoray/azure-sdk-for-rust
that referenced
this pull request
Oct 3, 2023
The original change in Azure#1431 was built & tested on a machine with the timezone of GMT, which is effectively UTC as it relates to the testing. In addition to fixing the conversion, this adds a unit test for unix platforms that temporarily changes the `TZ` environment variable (used for setting the timezone for libc platforms), performs the conversion, then resets the `TZ` environment variable. This validates the functionality regardless of the testing environment.
demoray
added a commit
that referenced
this pull request
Oct 4, 2023
The original change in #1431 was built & tested on a machine with the timezone of GMT, which is effectively UTC as it relates to the testing. In addition to fixing the conversion, this adds a unit test for unix platforms that temporarily changes the `TZ` environment variable (used for setting the timezone for libc platforms), performs the conversion, then resets the `TZ` environment variable. This validates the functionality regardless of the testing environment.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #1371, there are numerous issues with handling the az-cli's output of an access token's expiration date when it comes to time zones.
An update to the Azure CLI is in progress that will add a new field that will handle the conversion, currently tracked as Azure/azure-cli#27476.
We should make use of this new feature once it's available, but we should also keep this functionality as a fallback for supporting older Azure CLIs.