[WIP] [Common Recorder] Tests with this.skip() must execute the afterEach hook #6833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
added
Client
HarshaNalluru
changed the title
|
Closing as we have already moved to mocha v7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This is a bug in the mocha library that afterEach block is not being executed if a test is skipped unlike beforeEach.
The issue is fixed in mocha 7.0.0 - mochajs/mocha#3741
However, after updating mocha to 7.0.0 in the package.json,
rush updatefailed as below.This issue occurred because
mocha-multiis still relying on an older version ofmocha.For comparison, npm throws a warning only
Logged an issue in the mocha-multi repo asking them to support mocha@7.0.0
Issue - #5697