[keyvault-keys] Fixed the recordings #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Oct 23, 2019
| @@ -39,7 +39,12 @@ describe("Keys client - create, read, update and delete operations", () => { | |||
| await testClient.flushKey(keyName); | |||
| }); | |||
|
|
|||
| // If this test is not skipped in the browser's playback, no other test will be played back. | |||
| // This is a bug related to the browser features of the recorder. | |||
There was a problem hiding this comment.
Do we want to log an issue for tracking the long term fix? Or is there no long term fix needed?
There was a problem hiding this comment.
I added this as the first item on this issue: #4229
ramya-rao-a
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change the API, so I'm hoping we can merge it.