Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for sideEffects field set to false #5022

Merged
merged 2 commits into from
Sep 6, 2019
Merged

check for sideEffects field set to false #5022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5966120
check for sideEffects field set to false
KarishmaGhiya Sep 5, 2019
35789f4
revert sideEffects settings to true for core-paging and core-asyncite…
KarishmaGhiya Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/core/core-amqp/package.json
View file
Open in desktop
Expand Up @@ -44,6 +44,7 @@
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/core/core-amqp",
"sideEffects": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a setting mostly used by WebPack. Since rollup doesn't use it and has it's own mechanism, doesn't seem like we should be adding this. More context -rollup/rollup#2593
Deferring to @bterlson for any other insights

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our customers may be using the package with webpack, which is why it can be useful to have this field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is for customer bundling more than our own. Webpack is far and away the most popular tool for this.

"repository": {
"type": "git",
"url": "https://github.com/azure/azure-sdk-for-js.git"
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-asynciterator-polyfill/package.json
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@
"unit-test:node": "echo skipped",
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
},
"sideEffects": true,
"sideEffects": false,
"private": false,
"devDependencies": {
"@types/node": "^8.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-paging/package.json
View file
Open in desktop
Expand Up @@ -55,7 +55,7 @@
"unit-test:node": "echo skipped",
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
},
"sideEffects": true,
"sideEffects": false,
"private": false,
"dependencies": {
"@azure/core-asynciterator-polyfill": "1.0.0-preview.1"
Expand Down
1 change: 1 addition & 0 deletions sdk/cosmosdb/cosmos/package.json
View file
Open in desktop
Expand Up @@ -28,6 +28,7 @@
"tsconfig.json"
],
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/cosmosdb/cosmos#readme",
"sideEffects": false,
"types": "./dist/index.d.ts",
"engine": {
"node": ">=8.0.0"
Expand Down