[Data Plane] pins rollup to 1.13.1 #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
force-pushed
the
pin-rollup
branch
2 times, most recently
from
724032b
to
083496f
Compare
ramya0820
requested review from
bsiegel,
mikeharder,
KarishmaGhiya and
ramya-rao-a
ramya0820
approved these changes
Jun 6, 2019
There was a problem hiding this comment.
LGTM, might want to wait for Eng Sys to review @mikeharder @bsiegel
mikeharder
approved these changes
Jun 6, 2019
KarishmaGhiya
approved these changes
Jun 6, 2019
bsiegel
suggested changes
Jun 6, 2019
There was a problem hiding this comment.
Since rollup is a direct dependency, we should change our package.json files to simply reflect the version requirement we want:
"rollup": "~1.13.1"
Rather than using the global override mechanism provided by preferredVersions. That should only be used when we need to pin a transitive dependency we have no direct control over.
ramya-rao-a
approved these changes
Jun 7, 2019
|
@bsiegel |
bsiegel
suggested changes
Jun 7, 2019
chradek
force-pushed
the
pin-rollup
branch
3 times, most recently
from
3f7b07b
to
123ea67
Compare
|
@bsiegel |
ramya0820
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup versions >= 1.14.0 introduced a change that is causing our test rollup bundle to break. This version was released earlier today and we're specifically seeing integration test failures in
@azure/event-bus.This change pins rollup to version
1.13.1, which gets integration tests back to a mostly working state.See #3484 for more information.