[JS] [Service Bus] Small changes after type definitions were added to https-proxy-agent #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once https-proxy-agent type definitions are added, these changes will be necessary to make this sample work. The PR that introduces the TypeScript definitions to https-proxy-agent is: TooTallNate/proxy-agents#66 This commit is related to #3064
sadasant
added
Client
ramya-rao-a
reviewed
May 21, 2019
sdk/servicebus/service-bus/samples/typescript/gettingStarted/useProxy.ts
Outdated
Show resolved
Hide resolved
|
We cannot merge this PR until a new version of http-proxy-agent is available right? |
|
@ramya-rao-a ok! I'll close it for now (but I won't remove the branch) 🌞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once https-proxy-agent type definitions are added,
these changes will be necessary to make this sample work.
The PR that introduces the TypeScript definitions to https-proxy-agent
is:
TooTallNate/proxy-agents#66
This PR doesn't technically fix #3064 by itself, but without this PR, #3064 won't be solved.
Feedback is welcome!