Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] Migrate UsernamePasswordCredential to MSALClient #29656

Merged
merged 8 commits into from May 13, 2024
Merged

[identity] Migrate UsernamePasswordCredential to MSALClient #29656

merged 8 commits into from May 13, 2024

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented May 9, 2024 •
edited

Packages impacted by this PR

@azure/identity

Issues associated with this PR

Resolves #29409

Describe the problem that is addressed by this PR

Migrates UsernamePasswordCredential to the MSALClient flow, simplifying the implementation.

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).
  • Add MSALClient recorded test

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@maorleger maorleger marked this pull request as ready for review May 10, 2024 16:22
@maorleger maorleger requested review from KarishmaGhiya, schaabs and a team as code owners May 10, 2024 16:22
xirzec
xirzec approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, all my comments are mostly about existing issues in the code and aren't blocking.

sdk/identity/identity/src/credentials/usernamePasswordCredential.ts Outdated Show resolved Hide resolved
sdk/identity/identity/test/internal/node/usernamePasswordCredential.spec.ts Outdated Show resolved Hide resolved
sdk/identity/identity/test/node/msalNodeTestSetup.ts Outdated Show resolved Hide resolved
@maorleger maorleger enabled auto-merge (squash) May 13, 2024 17:12
@maorleger maorleger merged commit fa4fd3a into Azure:main May 13, 2024
14 checks passed
@maorleger maorleger deleted the msal-client-username-password branch May 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec approved these changes

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-identity

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSALClient - Migrate usernamePasswordCredential
3 participants
@maorleger @azure-sdk @xirzec