rush update --full and testing #29471
#29655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
ckairen,
deyaaeldeen and
jeremymeng
as code owners
…zure/azure-sdk-for-js into harshan/rush-update-full
HarshaNalluru
requested review from
mikeharder,
weshaggard and
benbp
as code owners
HarshaNalluru
changed the title
rush update --full and testing #29471
|
/azp run js - storage - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run js - appconfiguration - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
… harshan/rush-update-full
… harshan/rush-update-full
… harshan/rush-update-full
- remove fallback sanitizers - add removeCentralSanitizers option to the recorder start options
HarshaNalluru
requested review from
vinjiang,
jiacfan,
ljian3377,
KarishmaGhiya,
maorleger,
schaabs and
a team
as code owners
HarshaNalluru
requested review from
pvaneck,
ahsonkhan,
scottaddie and
mpodwysocki
|
API change check API changes are not detected in this pull request. |
1 similar comment
|
API change check API changes are not detected in this pull request. |
HarshaNalluru
commented
May 14, 2024
| @@ -66,7 +66,7 @@ | |||
| "test:node": "npm run clean && npm run unit-test:node && npm run integration-test:node", | |||
| "test": "npm run clean && npm run build:test && npm run unit-test && npm run integration-test", | |||
| "unit-test:browser": "dev-tool run test:browser", | |||
| "unit-test:node": "dev-tool run test:node-ts-input -- --timeout 300000 --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'", | |||
| "unit-test:node": "echo skipped", | |||
There was a problem hiding this comment.
Wish to handle identity in a follow up PR as it is uncertain on recording with various credentials
jeremymeng
approved these changes
May 14, 2024
| @@ -27,7 +27,8 @@ const replaceableVariables: Record<string, string> = { | |||
| }; | |||
|
|
|||
| const recorderOptions: RecorderStartOptions = { | |||
| envSetupForPlayback: replaceableVariables | |||
| envSetupForPlayback: replaceableVariables, | |||
| removeCentralSanitizers: ["AZSDK3493"] | |||
There was a problem hiding this comment.
Are there docs on when and what sanitizers people need to remove?
There was a problem hiding this comment.
I saw in some packages like storage-blob, there is a comment on why we don't need the x-ms-encryption-key-sha256 sanitizer. I'd love to have this guideline too.
There was a problem hiding this comment.
Scott is working on the docs Azure/azure-sdk-tools#8142
I've added comments for all the current usages.
KarishmaGhiya
approved these changes
May 14, 2024
Closed
timovv
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's happening?
recorder 3.5.0withrecorder 3.5.0recorder 4.xwith therecorder 3.5.0changes and make sure they are in sync.rush update --fullto get latest recorder and test-credential packagesFuture Work