[Search] Refactor tests #29595
Merged
[Search] Refactor tests #29595
+689
−637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgetu
force-pushed
the
search/refactor-tests
branch
5 times, most recently
from
b5007b7
to
b27eb9c
Compare
2 tasks
dgetu
force-pushed
the
search/refactor-tests
branch
2 times, most recently
from
343602a
to
cc2ced3
Compare
|
API change check API changes are not detected in this pull request. |
dgetu
force-pushed
the
search/refactor-tests
branch
from
cc2ced3
to
e4cb613
Compare
dgetu
force-pushed
the
search/refactor-tests
branch
6 times, most recently
from
564fd36
to
9ba86c7
Compare
maorleger
approved these changes
May 10, 2024
sdk/search/search-documents/test/public/node/searchClient.spec.ts
Outdated
Show resolved
Hide resolved
| } from "../../../src"; | ||
| import { delay } from "../../../src/serviceUtils"; | ||
| import { COMPRESSION_DISABLED } from "../../compressionDisabled"; | ||
| import { Hotel } from "./interfaces"; | ||
|
|
||
| export const WAIT_TIME = isPlaybackMode() ? 0 : 4000; | ||
|
|
||
| function uniqueNameGenerator() { |
There was a problem hiding this comment.
Would a uuid from @azure/core-util work here instead? Meaning deleting this helper and just using uuids for unique names
There was a problem hiding this comment.
I'd like for these names to be human-readable and deterministic. Maybe we can leverage a hash function instead?
dgetu
force-pushed
the
search/refactor-tests
branch
from
9ba86c7
to
1ef237d
Compare
dgetu
force-pushed
the
search/refactor-tests
branch
from
1ef237d
to
4d9522a
Compare
maorleger
reviewed
May 16, 2024
| assert.equal(correctServiceVersion, client.apiVersion); | ||
| }); | ||
|
|
||
| it("prioritizes `serviceVersion` over `apiVersion", () => { |
There was a problem hiding this comment.
It's a common miss when deprecating a field for another field (wha thappens if I pass both) - glad you're thinking and testing this!
maorleger
approved these changes
May 16, 2024
dgetu
force-pushed
the
search/refactor-tests
branch
from
4d9522a
to
bd464de
Compare
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/search-documents
Describe the problem that is addressed by this PR
A small refactor of tests to support 2024-05 test cases
Designed to be reviewed on a per-commit basis.
Depends on #29600
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists