[OpenAI] [Assistants] Add fileIds to Thread messages #29500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glharper
requested review from
bterlson,
xirzec,
jeremymeng,
mpodwysocki,
deyaaeldeen and
minhanh-phan
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
deyaaeldeen
reviewed
Apr 29, 2024
deyaaeldeen
approved these changes
Apr 29, 2024
3 tasks
glharper
pushed a commit
that referenced
this pull request
Apr 30, 2024
### Packages impacted by this PR @azure/openai-assistants ### Issues associated with this PR #29500 only updated the types, not the actual operations ### Describe the problem that is addressed by this PR With #29500 PR, the `fileIds` type is added, but the actual operations (`createThread` and `createThreadAndRun`) are still missing the `file_ids` property in the message objects. This PR adds `file_ids` to both of these two operations. Additionally, there are some other fixes: * The `AssistantThreadCreationOptions` in `rest/models.ts` was not updated along with #29500 PR. * The `AssistantThreadCreationOptions` type in `api/operations.ts` was incorrectly importing from `rest/index`, instead it should be importing from `models/models`. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29473
Packages impacted by this PR
@azure/openai-assistants
Issues associated with this PR
#29473
Describe the problem that is addressed by this PR
Add fileIds to Thread messages
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists